fix: frontmatter parsing in windows (CLRF) #2631
Conversation
There was a problem hiding this comment.
I think we can make this a bit nicer + more robust by using a regex to extract the frontmatter.
If we use firstBlock.text.match(/^(---\r?\n)([\s\S]+)(\r?\n---\r?\n)/), we'll either have a returned object with how much we need to skip when reporting error positions (match[1].length), the yaml text to parse (match[2].length) and the new start position of the first block (match[0].length), or no object, in which case there wasn't frontmatter. Thoughts?
This will also handle the issue where a file has mixed line endings, as some people don't normalize those...
|
I spent a bit more time looking at this... and turns out that earlier assumption was bad because of eemeli/yaml#127, I ended up pulling your branch to play around with how to fix that, and fixed it another way.. |
fixes #2628
It's not pretty but it works. ^^